[WONT Bounty #86] Redesigning an engine does not recompute engine type skill effects

[thexa4]

Steps to reproduce:

1. Go to R&D
   
2. Click Modify design of engine `1935 Electric`
   
3. Click redesign
   
4. Note that Engine Length and Width are 914mm x 838mm.
   
5. Click on Layout
   
6. Under Engine Layout, reselect Electric
   
7. Note that Engine Length and Width are now 711mm x 685mm
   

Before:
   

After:
   

[Eric.B]

I got a chance to look at this, and it isn't actually a bug.

It has to do with this issue: https://www.ventdev.com/forums/showthread.php?tid=3868

Internally, every engine has a bore and stroke value saved, even if the engine type doesn't use them. This is used to calculate the size of the engine.

Every year the minimum and maximum bore/stroke values decreases. When you change the layout component, it resets the Bore/Strike values to the percentage of the bore/stroke sliders (even if you don't see it) within that range.

So, in short, Bounty #86 will fix this issue.